Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear transaction after rollback to avoid rollbacked messages getting used in the next transaction #134

Merged
merged 1 commit into from
Jul 19, 2020

Conversation

KayWu
Copy link
Contributor

@KayWu KayWu commented Jul 16, 2020

Issue #133

@KayWu KayWu changed the title ISSUE #133 - Fix/transaction fail Issue #133 - Fix/transaction fail Jul 16, 2020
@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #134 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #134   +/-   ##
=========================================
  Coverage     94.20%   94.21%           
  Complexity      455      455           
=========================================
  Files            38       38           
  Lines          1070     1071    +1     
  Branches         49       49           
=========================================
+ Hits           1008     1009    +1     
  Misses           45       45           
  Partials         17       17           
Impacted Files Coverage Δ Complexity Δ
.../com/github/fridujo/rabbitmq/mock/MockChannel.java 90.75% <100.00%> (+0.03%) 123.00 <0.00> (ø)
...va/com/github/fridujo/rabbitmq/mock/MockQueue.java 95.19% <0.00%> (ø) 81.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9a7a1...6ce7181. Read the comment docs.

@ledoyen
Copy link
Contributor

ledoyen commented Jul 16, 2020

Hi @KayWu, thank you for spotting and fixing this !

Can you please squash the two commits into one so I can merge the PR ?

Thanks in advance

@ledoyen ledoyen added the bug Something isn't working label Jul 16, 2020
@ledoyen ledoyen changed the title Issue #133 - Fix/transaction fail Clear transaction after rollback to avoid rollbacked messages getting used in the next transaction Jul 16, 2020
@KayWu
Copy link
Contributor Author

KayWu commented Jul 17, 2020

Hi @ledoyen, I have squashed the two commits into one.
Thanks for reviewing.

@ledoyen ledoyen merged commit 6793a08 into fridujo:master Jul 19, 2020
@KayWu
Copy link
Contributor Author

KayWu commented Jul 22, 2020

@ledoyen May I ask when is the next release?
I need to upgrade the lib once it releases.

@ledoyen
Copy link
Contributor

ledoyen commented Jul 22, 2020

@KayWu I just released a new version, it should be available in Maven Central within 2 hours.

@KayWu
Copy link
Contributor Author

KayWu commented Jul 23, 2020

Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants