Update sip-009-nft-standard.md #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearranged the content to be consistent with SIP-010
Zk2u
approved these changes
Mar 16, 2021
friedger
reviewed
Mar 16, 2021
| | function | error | description | | ||
| |----------|-------|-------------| | ||
| |`transfer`|`{kind: "nft-transfer-failed", code: from-nft-transfer}`| Error if the call failed due to the underlying asset transfer. The code `from-nft-transfer` is the error code from the native asset transfer function| | ||
| In addition to built-in methods for non-fungible token contracts, the Stacks blockchain includes a feature known as Post Conditions. By defining post conditions, users can create transactions that include pre-defined guarantees about what might happen in that contract. |
There was a problem hiding this comment.
This should not be part of the standard
There was a problem hiding this comment.
I was trying to accommodate this implementation rule you listed: "Contracts must use a least one NFT asset. A post-condition with deny mode and without any NFT condition about a changed owner must fail for transfer function calls." Isn't it not a post condition? should I rephrase it or remove it?
Zk2u
approved these changes
Mar 16, 2021
|
@muneebm Thank you for the contribution! The changes has been added. Due to conflicts in a new commit. Would you like to add your email address in the author section as a PR |
friedger
pushed a commit
that referenced
this pull request
Jan 20, 2022
Add specifics for bitcoin vote op, proposed changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@friedger First of all, thank you very much for taking the initiative (as always) for creating this standard. I have made a few changes to make it consistent with SIP-010 and rearranged the content a little bit. Please see if the changes can be merged.