Cleanup according to PHPStorm inspection part 1: Update PHPDoc #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2019
JeroenED
suggested changes
Jan 9, 2019
|
Conflict fixed. |
annando
approved these changes
Jan 9, 2019
|
Conflicts again 😁 |
|
Solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux of #6401
Part of #4176
Related to #6406, #6407, #6408
This is an impact-less PR, only adding the
@throwsPHPDoc tags where required. We started using Exception but there are few places where we actually catch them. As such most function are susceptible to throw one or more different exceptions, and it should be reflected in the PHPDoc comment.