Cleanup according to PHPStorm inspection part 3: Remove unused code #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove commented code - Remove unused/immediately overwritten variables - Remove extraneous parameters - Remove unreachable code - Remove duplicate array keys
- Remove commented code - Remove unused/immediately overwritten variables - Remove extraneous parameters - Remove unreachable code
- Remove unused variables
MrPetovan
force-pushed
the
task/6401-3-remove-unused-code
branch
from
ba01d9b
to
e9ad058
Compare
This was referenced Jan 7, 2019
|
Conflicts 😁 |
|
Solved. |
|
Just some side note: having the |
|
Do you want me to fix the existing instances where |
|
No, I just saw changed lines with this and wanted to make a wish for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux of #6401
Part of #4176
Related to #6404, #6406, #6408
This should be an impact-less PR. Only unused code has been removed, and each instance has been verified by hand, although not actually tested on a system.