Cleanup according to PHPStorm inspection part 4: Fix potential bugs #6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 7, 2019
annando
requested changes
Jan 9, 2019
- Fix uninitialized variables - Fix potentially not set variables - Fix wrong parameter default value - Fix method scope - Fix missing return value
MrPetovan
force-pushed
the
task/6401-4-fix-potential-bugs
branch
from
b89b496
to
7794ef9
Compare
|
Conflicts fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux of #6401
Part of #4176
Related to #6404, #6406, #6407
This is the real piece de resistance of this string of PRs. Most of these changes are expected to change Friendica behavior one way or another. Because of this, changes have been neatly broken down into individual commit for your reviewing pleasure/reverting convenience.
This is also the PR that should bring the most shame to Friendica developers given the outlandish nature of some of the mistakes that were made.