Add memberObj in @at event #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritx
requested changes
Mar 25, 2018
src/At.vue
Outdated
| return i; | ||
| } | ||
| }); | ||
| this.$emit('at', memberObj); |
There was a problem hiding this comment.
It would cause a breaking change which we should try to avoid 😃
| @@ -17,6 +17,7 @@ | |||
| <ul class="atwho-ul"> | |||
| <li v-for="(item, index) in atwho.list" | |||
| class="atwho-li" | |||
| :key="index" | |||
src/At.vue
Outdated
| @@ -255,7 +255,12 @@ export default { | |||
| } else { | |||
| const { members, filterMatch, itemName } = this | |||
| if (!keep && chunk.length>0) { | |||
| this.$emit('at', chunk) | |||
| const memberObj = Object.values(this.members).filter((i) => { | |||
There was a problem hiding this comment.
I'm worried about cross-browser compatibility of Object.values (not supported in IE, etc)
https://caniuse.com/#search=object.values
|
@fritx I updated the code with the requested changes! |
fritx
reviewed
Mar 27, 2018
src/At.vue
Outdated
| } | ||
| }); | ||
| this.$emit('at', memberObj); | ||
| this.$emit('at', memberObj) |
There was a problem hiding this comment.
Great, but I had thought what if we $emit('at', chunk, memberObj)
the memberObj as the third arg... lol
There was a problem hiding this comment.
so that we could let go the new added prop showMemberObj
|
Yes, it seems a better way to write it, sorry about that hahaha
On Tue, 27 Mar 2018 at 01:10 Fritz Lin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/At.vue
<#50 (comment)>:
> }
});
- this.$emit('at', memberObj);
+ this.$emit('at', memberObj)
Great, but I had thought what if we $emit('at', chunk, memberObj)
the memberObj as the third arg... lol
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGlOf6hWMpa-HcjScEiz5TF9DuQCsEyRks5tibvHgaJpZM4S5H-6>
.
--
Att, Ricardo Goldstein via iPhone
|
|
@fritx just add the third argument. |
fritx
added a commit
that referenced
this pull request
Mar 28, 2018
@at events were always broken, need to be fixed
|
@goldsteinr thanks for the PR, but I made some further changes:
<at @insert="handleInsert"></at>
methods: {
handleInsert (item) { /* ... */ }
} |
|
@fritx cool :) can we get a release of it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the possibility to get the member's array object instead of just the text.
Example: I want a user email and not only his name. With the handler now, we get the member obj to use any information we want.
closes #49