using tar/unzip util to handle archive instead of golang lib #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation does not handle symlink & hardlink, make the inflated file corrupted. Using native tar/unzip utility for the best result without the trouble to implement a full featured archiver.
|
Thanks @fredwangwang |
This was referenced Jan 4, 2019
|
@fredwangwang FYI, after merging this PR, I realized the integration tests were failing (see Job #33.2), because the archive files were deleted after uncompressing them. I've restored the previous gunzip logic (1523853) in order to preserve the original file ( |
|
Thats alright. The removal of the original file is copied directly from s3
resource. Thanks for the info
…On Fri, Jan 4, 2019, 12:01 PM Ferran Rodenas ***@***.*** wrote:
@fredwangwang <https://github.com/fredwangwang> FYI, after merging this
PR, I realized the integration tests were failing (see Job #33.2
<https://travis-ci.org/frodenas/gcs-resource/jobs/475396305#L490>),
because the archive files were deleted after uncompressing them.
I've restored the previous gunzip logic (1523853
<1523853>)
in order to preserve the original file (gunzip does not preserve the file
name) and also removed the os.Remove calls (b518cc2
<b518cc2>).
This should not affect the symlink & hardlink, as it's still using
untar/unzip.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUr56XwI7RB3aT39lu2Ptk2VoDUHJdSzks5u_6UdgaJpZM4ZkC22>
.
|
jtarchie
referenced
this pull request
in pivotal-cf/azure-blobstore-resource
Dec 4, 2019
- don't rely on shelling out to packages because they no longer exist on cf-tiny (fixes #32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation does not handle symlink & hardlink, make the inflated file corrupted.
Using native tar/unzip utility for the best result without the trouble to implement a full-featured archiver.
Specific command copied directly from concourse/s3-resource
Note: before I copied the command from S3-resource, I also tried https://github.com/mholt/archiver as a replacement. But turns out it only works partially. The file I tested with is a Docker container archive, which is a rather complicated target.
mholt/archiverwas not able to handle some of the contents (links, especially, seems like links redirect several times is a nightmare to handle) in the archive. So I went with tar & unzip utilities, works perfectly. (Why Reinvent the wheel when there is a perfect one last decades? 😄)