-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly clippy raises warning "unneeded unit expression" #66
Comments
martinvonz
added a commit
to martinvonz/test-case
that referenced
this issue
Jun 15, 2021
It seems that `quote!` implements `ToTokens` for `Option` such that we can use a `Option<Expr>` for optionally emitting #expected here.
martinvonz
added a commit
to martinvonz/jj
that referenced
this issue
Jun 26, 2021
This is work around frondeus/test-case#66 until my pull request (or other fix) gets accepted.
luke-biel
added a commit
that referenced
this issue
Jun 27, 2021
Avoid emitting "unneeded unit expression" (issue #66)
This should be fixed in 1.2.0, i'll take liberty of closing this Issue. |
martinvonz
added a commit
to martinvonz/jj
that referenced
this issue
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clippy raises a warning to the following code.
Messages from clippy,
I think this warning should be suppressed in macro, or we should modify the macro not to use unit expressions, if possible.
The text was updated successfully, but these errors were encountered: