Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing roles for user shows the user as "pending approval" until refresh #99

Closed
aviadmizrachi opened this issue Nov 11, 2020 · 0 comments · Fixed by #104 or #105
Closed

Changing roles for user shows the user as "pending approval" until refresh #99

aviadmizrachi opened this issue Nov 11, 2020 · 0 comments · Fixed by #104 or #105
Assignees
@aviadmizrachi @frontegg-david
Labels
bug Something isn't working

Comments

@aviadmizrachi
Copy link
Contributor

Describe the bug
Changing roles for user shows the user as "pending approval" until refresh

To Reproduce

  1. Go to 'Team page
  2. Update roles for user

==> The roles are modified BUT User last login switches to "pending approval"

Expected behavior
Only the roles should change
@aviadmizrachi aviadmizrachi added the bug Something isn't working label Nov 11, 2020
frontegg-david pushed a commit that referenced this issue Nov 15, 2020
@davidantoon
fix(auth): remain user data after editing roles in TeamTable
186aaa4 
update property that has been editted only

#99
@frontegg-david frontegg-david mentioned this issue Nov 15, 2020
Merged
frontegg-david added a commit that referenced this issue Nov 15, 2020
@frontegg-david
Merge pull request #104 from frontegg/auth-plugin-fixes
82f9516 
feature: redirect user to login with two-factor after saml if required
fix: multiple store initialization in strict-mode
fix: remove last role in TeamTable
fix: remain user data after editing roles in TeamTable

Resolves #99, resolves #101, resolves #103
@frontegg-david frontegg-david linked a pull request Nov 15, 2020 that will close this issue
v1.6.1 #105
Merged
@frontegg-david frontegg-david mentioned this issue Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aviadmizrachi aviadmizrachi

@frontegg-david frontegg-david

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auth plugin fixes frontegg/frontegg-react
v1.6.1 frontegg/frontegg-react
2 participants
@aviadmizrachi @frontegg-david