Code Updates and Refactoring #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nuzzy
commented
Aug 26, 2020
nuzzy
commented
- Fixed "composer.json" file to be valid.
- Refactored ApiErrors to be a part of ApiErrorTrait.
- Refactored getDecodedJsonData() method to be a part of ApiJsonTrait.
- Updated directory structure for Events.
- Updated Audits GET request to properly send query parameters.
- Updated tests.
- Other small changes.
* Fixed "composer.json" file to be valid. * Refactored ApiErrors to be a part of ApiErrorTrait. * Refactored getDecodedJsonData() method to be a part of ApiJsonTrait. * Updated directory structure for Events. * Updated Audits GET request to properly send query parameters. * Updated tests. * Other small changes.
aviadmizrachi
approved these changes
Aug 26, 2020
aviadmizrachi
pushed a commit
that referenced
this pull request
Sep 1, 2020
* Task "Build authenticator". (#1) * Task "Build authenticator". * Created Frontegg main class. * Created Helper classes. * Created "readme.md" file. * Created "composer.json" file with package dependencies. * Created tests for base functionality. * Task "Build authenticator". * Update Frontegg main class. * Updated Helper classes. * Updated "readme.md" file. * Updated "composer.json" file "ext-curl" dependency. * Updated tests for base functionality. * Task "Build authenticator". * Update Frontegg main class. * Updated Helper classes. * Updated "readme.md" file. * Updated "composer.json" file "ext-curl" dependency. * Updated tests for base functionality. * Task "Build Authenticator" * Updated code style using CodeSniffer and PhpStan. * Updated "composer.json" * Audits SDK (#2) * Task "Build authenticator". * Created Frontegg main class. * Created Helper classes. * Created "readme.md" file. * Created "composer.json" file with package dependencies. * Created tests for base functionality. * Task "Build authenticator". * Update Frontegg main class. * Updated Helper classes. * Updated "readme.md" file. * Updated "composer.json" file "ext-curl" dependency. * Updated tests for base functionality. * Task "Build authenticator". * Update Frontegg main class. * Updated Helper classes. * Updated "readme.md" file. * Updated "composer.json" file "ext-curl" dependency. * Updated tests for base functionality. * Task "Build Authenticator" * Updated code style using CodeSniffer and PhpStan. * Updated "composer.json" * Task "Audits SDK" * Created new AuditsClient class for API calls to Audit Logs endpoints. * Updated main classes. * Created new tests for Audit Logs classes. * Updated and refactored existing tests. * Updated "readme.md" file. * Task "Audits SDK" * Fixed code styles. * Task "Audits Log" * Small fixes * Events SDK (#4) * Task "Events SDK" * Created basic classes for Events API. * Updated existing classes. * Created tests for Events API. * Other small changes. * Task "Events SDK" * Created basic classes for Events API. * Updated existing classes. * Created tests for Events API. * Other small changes. * Task "Events SDK" * Updated Events classes and tests. * Created class and tests for Slack channel. * Other small updates. * Task "Events SDK" * Fixed code styles. * Task "Events SDK" * Fixed an error with API URL. * Updated basic classes and tests. * Task "Events SDK" * Renamed config services constants. * Frontegg Middleware Proxy (#5) * Added Proxy functionality * Included `psr/http-message`, 'relay/relay', `guzzlehttp/psr7` packages * Intruduced `Proxy` class * Introduced `FronteggAdapter` class * Added `FronteggRequestHeaderResolver` and `FronteggRequestMethodResolver` * Adjusted `FronteggCurlHttpClient` with `DEFAULT_TIMEOUT` constant * Task "Events SDK" * Created basic classes for Events API. * Updated existing classes. * Created tests for Events API. * Other small changes. * Task "Events SDK" * Created basic classes for Events API. * Updated existing classes. * Created tests for Events API. * Other small changes. * Task "Events SDK" * Updated Events classes and tests. * Created class and tests for Slack channel. * Other small updates. * Task "Events SDK" * Fixed code styles. * Task "Frontegg middleware" * Updated Proxy classes. * Created tests for Proxy classes. * Task "Events SDK" * Fixed an error with API URL. * Updated basic classes and tests. * Task "Frontegg Middleware" * Updated basic classes and tests. * Created Proxy filter classes. * Other changes. * Task "Events SDK" * Renamed config services constants. * Task "Frontegg Middleware" * Updated and refactored Proxy classes. * Added new tests for Proxy middleware. * Task "Frontegg Middleware" * Fixed code styles. * Task "Frontegg Middleware" * Fixed merge conflicts. * Task "Frontegg Middleware" * Updated Proxy classes to properly handle POST requests. * Created tests for Proxy API. Co-authored-by: Daniel Kleba <klebadanial@gmail.com> * Task "Docs Update" (#9) * Updated "readme.md" * Task "Code Updates and Refactoring" (#11) * Fixed "composer.json" file to be valid. * Refactored ApiErrors to be a part of ApiErrorTrait. * Refactored getDecodedJsonData() method to be a part of ApiJsonTrait. * Updated directory structure for Events. * Updated Audits GET request to properly send query parameters. * Updated tests. * Other small changes. * Task "Run tests on github on push" (#12) * Added Github workflow to run phpunit tests. * Removed credentials from the tests. * Created phpunit.xml config file * Demo Using Docker Env (#10) * Task "Docker demo for raw PHP" * Created demo environment with docker for raw PHP. * Docker demo for raw PHP * Removed credentials from the code. * Updated code. * Task "Demo site on Docker env" * Updated demo site in "docker/index.php". * Updated "docker-compose.yml" file. * Removed credentials from the tests. * Task "Fix sending event trigger channels bug" (#13) * Updated Events channel classes. * Updated and added tests for new code changes. * Updated "readme.md" file. Co-authored-by: Daniel Kleba <klebadanial@gmail.com>
aviadmizrachi
pushed a commit
that referenced
this pull request
Sep 21, 2020
* Task "Build authenticator". (#1) * Task "Build authenticator". * Created Frontegg main class. * Created Helper classes. * Created "readme.md" file. * Created "composer.json" file with package dependencies. * Created tests for base functionality. * Task "Build authenticator". * Update Frontegg main class. * Updated Helper classes. * Updated "readme.md" file. * Updated "composer.json" file "ext-curl" dependency. * Updated tests for base functionality. * Task "Build authenticator". * Update Frontegg main class. * Updated Helper classes. * Updated "readme.md" file. * Updated "composer.json" file "ext-curl" dependency. * Updated tests for base functionality. * Task "Build Authenticator" * Updated code style using CodeSniffer and PhpStan. * Updated "composer.json" * Audits SDK (#2) * Task "Build authenticator". * Created Frontegg main class. * Created Helper classes. * Created "readme.md" file. * Created "composer.json" file with package dependencies. * Created tests for base functionality. * Task "Build authenticator". * Update Frontegg main class. * Updated Helper classes. * Updated "readme.md" file. * Updated "composer.json" file "ext-curl" dependency. * Updated tests for base functionality. * Task "Build authenticator". * Update Frontegg main class. * Updated Helper classes. * Updated "readme.md" file. * Updated "composer.json" file "ext-curl" dependency. * Updated tests for base functionality. * Task "Build Authenticator" * Updated code style using CodeSniffer and PhpStan. * Updated "composer.json" * Task "Audits SDK" * Created new AuditsClient class for API calls to Audit Logs endpoints. * Updated main classes. * Created new tests for Audit Logs classes. * Updated and refactored existing tests. * Updated "readme.md" file. * Task "Audits SDK" * Fixed code styles. * Task "Audits Log" * Small fixes * Events SDK (#4) * Task "Events SDK" * Created basic classes for Events API. * Updated existing classes. * Created tests for Events API. * Other small changes. * Task "Events SDK" * Created basic classes for Events API. * Updated existing classes. * Created tests for Events API. * Other small changes. * Task "Events SDK" * Updated Events classes and tests. * Created class and tests for Slack channel. * Other small updates. * Task "Events SDK" * Fixed code styles. * Task "Events SDK" * Fixed an error with API URL. * Updated basic classes and tests. * Task "Events SDK" * Renamed config services constants. * Frontegg Middleware Proxy (#5) * Added Proxy functionality * Included `psr/http-message`, 'relay/relay', `guzzlehttp/psr7` packages * Intruduced `Proxy` class * Introduced `FronteggAdapter` class * Added `FronteggRequestHeaderResolver` and `FronteggRequestMethodResolver` * Adjusted `FronteggCurlHttpClient` with `DEFAULT_TIMEOUT` constant * Task "Events SDK" * Created basic classes for Events API. * Updated existing classes. * Created tests for Events API. * Other small changes. * Task "Events SDK" * Created basic classes for Events API. * Updated existing classes. * Created tests for Events API. * Other small changes. * Task "Events SDK" * Updated Events classes and tests. * Created class and tests for Slack channel. * Other small updates. * Task "Events SDK" * Fixed code styles. * Task "Frontegg middleware" * Updated Proxy classes. * Created tests for Proxy classes. * Task "Events SDK" * Fixed an error with API URL. * Updated basic classes and tests. * Task "Frontegg Middleware" * Updated basic classes and tests. * Created Proxy filter classes. * Other changes. * Task "Events SDK" * Renamed config services constants. * Task "Frontegg Middleware" * Updated and refactored Proxy classes. * Added new tests for Proxy middleware. * Task "Frontegg Middleware" * Fixed code styles. * Task "Frontegg Middleware" * Fixed merge conflicts. * Task "Frontegg Middleware" * Updated Proxy classes to properly handle POST requests. * Created tests for Proxy API. Co-authored-by: Daniel Kleba <klebadanial@gmail.com> * Task "Docs Update" (#9) * Updated "readme.md" * Task "Code Updates and Refactoring" (#11) * Fixed "composer.json" file to be valid. * Refactored ApiErrors to be a part of ApiErrorTrait. * Refactored getDecodedJsonData() method to be a part of ApiJsonTrait. * Updated directory structure for Events. * Updated Audits GET request to properly send query parameters. * Updated tests. * Other small changes. * Task "Run tests on github on push" (#12) * Added Github workflow to run phpunit tests. * Removed credentials from the tests. * Created phpunit.xml config file * Demo Using Docker Env (#10) * Task "Docker demo for raw PHP" * Created demo environment with docker for raw PHP. * Docker demo for raw PHP * Removed credentials from the code. * Updated code. * Task "Demo site on Docker env" * Updated demo site in "docker/index.php". * Updated "docker-compose.yml" file. * Removed credentials from the tests. * Task "Fix sending event trigger channels bug" (#13) * Updated Events channel classes. * Updated and added tests for new code changes. * Updated "readme.md" file. * Update README file (#15) Co-authored-by: Daniel Kleba <klebadanial@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.