Include node info in rowHeight callback

[fritz-c]

No description provided.

[lifejuggler]

@fritz-c I will make a pull request

[lifejuggler]

@fritz-c actually can you give me more context to this issue? or maybe I can pick up another issue since I am not sure what this issue is trying to do or solve

[fritz-c]

Sorry for the delay. The issue here is that when people want to set the height per row with the rowHeight prop by giving it a callback, it only gives the index within the currently displayed rows as an argument.

A usage example: if I wanted to have rows that were twice as tall for nodes with a doubleHeight: true attribute in them, on every render call I would have to generate the flattened tree while hiding collapsed nodes, just to figure out which node that index was pointing at.

// API as it is now:
({ index }) => rowHeight

// API as I think it should be
({ index, treeIndex, node, path }) => rowHeight
// Nice-to-haves: lowerSiblingCounts, isSearchMatch, isSearchFocus
//   -> Include these if they are available in the context and
//      don't require extra calculation

// * Note that `treeIndex` and `index` should be the same value,
// I just want the APIs to be consistent in their naming.

[C3PablO]

Is there any way to go around this? to have different heights based based on node data?

[fritz-c]

@C3PablO Not right now. Would you be interested in adding the functionality? I believe it's only a matter of plugging in some extra variables into the callback call.

[C3PablO]

yes, I think that would be very useful. For what I've seen around the issues, there was a fix for this in 1.3.0 (a906f21). No sure where that went. Another solution I'm looking at is the possibility of wrapping the cell into a CellMeasurer for rows where the height is difficult to guess so the node height is set based on the content. Think of it as a list of comments.

[fritz-c]

That fix you refer to only applied to non-virtualized trees. For whatever reason I didn't notice the virtualized version didn't get any attention.

[wuweiweiwu]

@fritz-c if its not done already i can do it :)

[fritz-c]

@wuweiweiwu yes please!

[wuweiweiwu]

#231 pull request submitted!

[fritz-c]

Available now in v1.6.0. Thanks for the help!