Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blinkapp.py: Add missing await #768

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Sep 12, 2023

Add missing await for saving CREDFILE

Description:

Discovered missing await and fixed.

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Add missing await for saving CREDFILE
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #768 (58d2ee3) into dev (0c7c3a1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #768   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files           8        8           
  Lines        1404     1404           
=======================================
  Hits         1399     1399           
  Misses          5        5           
Flag Coverage Δ
unittests 99.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@fronzbot fronzbot merged commit f3ce27d into fronzbot:dev Sep 18, 2023
8 checks passed
@fronzbot fronzbot deleted the await-in-blinkapp branch September 18, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants