Make check of creating e-mail addresses case-insensitive, thanks to d4f, fixes #1021

[arnisoph]

No description provided.

[Linutux]

I think your code has a major problem: If I have created 123456@fqdn.tld and I want to add 3456@fqdn.tld it will fail because LIKE also matches 123456@fqdn.tld. I instead recommend to convert all e-mail adresses to lower-case before doing any query.

[arnisoph]

Should be solved now. Steps to reproduce:

1. create email address Foo@foo.tld
2. create email address foo@foo.tld => FAILS
3. create email address 123456@foo.tld
4. create email address 456@foo.tld => FAILS

@Froxlor/froxlor-developers Please check, maybe modfiy and merge/reject

[Linutux]

Commit f957a0a seems fine to me.

All email adresses already in DB should also be converted to lowercase on Froxlor upgrade.

[avengerx]

I wonder without detailed code investigating... is not a better idea to make sure there's a strtolower before 'insert into mail_user' and 'insert into mail_virtual' in customer_email.php? So this kind of problem would be reproductible only if someone added the email into the database by hand? Is it desirable to have a "Foo@" email in the database instead of plain lowercase "foo@" regardless of how user typed during creation?

I think that fixing it where it is fixed is needed but still the database will be subject to having more uppercase emails thus future errors will happen again and again elsewhere in froxlor. :)