Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify behavior when creating a New Team from the character editor #1583

Closed
StainAE86 opened this issue Feb 29, 2024 · 1 comment · Fixed by #1655
Closed

Modify behavior when creating a New Team from the character editor #1583

StainAE86 opened this issue Feb 29, 2024 · 1 comment · Fixed by #1655
Assignees
Labels
enhancement New feature or request good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR teams For the teams + builds feature

Comments

@StainAE86
Copy link
Collaborator

Currently if you click "Add Team" from within the character editor you are presented with this:

image

Default name is "Team Name" and it skips the character selector popup.
As you can no longer add team mates via the Team Buffs tab this now requires an additional page to navigate to complete the workflow of creating a team and getting an optimization result.

I suggest doing the following:
image

After clicking "Add Team" it creates the new team but forcefully opens the Team Settings popup so you can start adding additional team members straight away.
And the default Team Name is: "Character Name" Team

@StainAE86 StainAE86 added enhancement New feature or request teams For the teams + builds feature labels Feb 29, 2024
@frzyc
Copy link
Owner

frzyc commented Mar 1, 2024

Here is the firm requirements:

  • When creating a new team from the character editor, allow the navigation to pass a prop to open the team settings popup.
  • No changes to default Team Name(will be addressed by something else)

@frzyc frzyc added the good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR label Mar 1, 2024
@frzyc frzyc self-assigned this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR teams For the teams + builds feature
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants