Event signup info added to event cards, infinite event scroll, bug fixes #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkrantz
requested review from
olofenglund96,
navro,
FredrikLastow and
tonitajger
houndci-bot
reviewed
Nov 29, 2018
olofenglund96
force-pushed
the
david-event-card
branch
from
e0af212
to
0535111
Compare
houndci-bot
reviewed
Nov 29, 2018
olofenglund96
force-pushed
the
david-event-card
branch
from
0535111
to
38882fb
Compare
houndci-bot
reviewed
Nov 29, 2018
olofenglund96
requested changes
Dec 8, 2018
There was a problem hiding this comment.
Since we now want to try to use let and const (and don't care about older devices hehe) you can change the vars. I also left one comment regarding multiple lines of variable declarations. Otherwise really great stuff which will make cards more informative and better overall!! Good job!
davidkrantz
force-pushed
the
david-event-card
branch
from
38882fb
to
6a1b3d7
Compare
houndci-bot
reviewed
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few new features and bug fixes: