Refactor Symbol Cache #384
Conversation
How hard is it to replace it with something meaningful? |
Well, I removed the part of passing data with JSON completely. |
| res | ||
|
|
||
| let initializeCache dir = | ||
| let connectionString = sprintf "Data Source=%s/.ionide/symbolCache.db" dir |
There was a problem hiding this comment.
if we use /.ionide/obj , that will be git ignored by default by pratically all .gitignores, so less noise
There was a problem hiding this comment.
Another option is that it's passed as argument to FSAC.
So editors can put that:
- or in their temp directory or custom dir
- or can be in a dir inside %TEMP% generated for the workspace so valid until restart and automatically cleaned up.
| do if not dbExists then | ||
| let fs = File.Create(dbPath) | ||
| fs.Close() | ||
| let cmd = "CREATE TABLE Symbols( |
There was a problem hiding this comment.
this doesnt work if the schema will be updated later to v2.
for example an older symbolcache exists on file, and that's will be used but schema is v1
|
@Krzysztof-Cieslak btw travis is red also in master, after bfa7f58 was green before |
|
@enricosada, Regarding comments on code - I've only refactored code here for performance gain, the comments are relevant but I don't want to address them at the moment - it's just refactoring, I don't want to introduce any changes to the feature |
|
This is ready to merge. |
|
What a big chungus. It's always great looking at your first run of perf view :) |
It turns out that sending thousands of symbols serialized to JSON through HTTP is not the best idea I've ever had!
I've started working on some performance analyses, and while I don't have yet lot of experience with it there was one big elephant in the room that was noticeable even for me:
The absurd amount of
Int32allocations caused by Newtonsoft.Json.GC Heap Alloc Ignore Free:
Turns out this all was caused by single function -
SymbolCache.sendSymbolsthat caused 56% of allocations, and was causing 12% of CPU usage:GC Heap Alloc Ignore Free:
CPU Stack:
It was also causing ~40% of Large Object allocations:
GC Heap Alloc Ignore Free:
After the refactoring main FSAC process inserts symbols to SQLite directly, and only sends notification to the SymbolCache process that the DB was updated and it should be loaded to memory.
After the refactoring
SymbolCache.sendSymbolscauses 5% of CPU usage and 14% of allocations:GC Heap Alloc Ignore Free:
CPU Stack:
I've also observed decrease on Large Object allocations from around 3% to 1% and GCStats are not showing any LOH allocation pauses.
Pre refactoring:
Post refactoring:
