-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target netstandard2.0 #391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c/csproj ProjectSdk format* Deedle targets net45 and netstandard2.0* Deedle.Test targets net45 and netcoreapp2.0* use AssemblyBuilder* updated packages* Fixed documentation content and samples* Updated build script similair to whats being used by FSharp.Data
Fix build
Trigger travis build. |
THis is great work. @kblohm Could you do a post-hoc review? thanks |
Sure i can.
|
@kblohm Thanks for your review. I've done a pull request to address some problems. Please take a look and let me know what you think.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes based on the initial efforts of @kblohm. Both Deedle and Deedle.RProvider compiles targeting dotnet standard now.