Distribution distance metrics #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvenn
requested changes
May 10, 2020
bvenn
reviewed
May 11, 2020
Comment on lines
91
to
93
| xCDF - yCDF | ||
| |> abs | ||
| |> (*) delta |
There was a problem hiding this comment.
Please consider to preserve formula notation. For users looking for the math behind the implementation it is easier to search for formulas seen in e.g. publications.
The same applies to lines 99 and 111
There was a problem hiding this comment.
Tried to adress this in ccbc8bf. What do you think?
Small performance and readability increase Co-authored-by: Benedikt Venn <venn@rhrk.uni-kl.de>
increase readability of getCDFIndices function Co-authored-by: Benedikt Venn <venn@rhrk.uni-kl.de>
|
Consider adding unit tests for the new functions. |
bvenn
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
for computing distances between distributions and affiliated documentation.
Resolving #70