Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magicmode #75

Merged
merged 14 commits into from
Jul 30, 2018
Merged

Magicmode #75

merged 14 commits into from
Jul 30, 2018

Conversation

jackfoxy
Copy link
Collaborator

  1. paket magic mode
  2. dotnet SDK style projects
  3. multitarget net45 and netstandard2.0

@jackfoxy jackfoxy mentioned this pull request Jul 20, 2018
Closed
@jackfoxy
Copy link
Collaborator Author

jackfoxy commented Jul 20, 2018 •
edited
Loading

Now Newtonsoft.Json also failing in VS 15.8 preview 4
The namespace or module 'Newtonsoft' is not defined.

Added
'''<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>'''
And it once again builds debug net45 and netstandard2.0 in VS
Build script builds release net45, but still fails on netstandard2.0

VS has no problem building release netstandard2.0

very strange

@dsyme
Copy link
Member

dsyme commented Jul 20, 2018

@jackfoxy are you merging with master or would you like me to do it? thanks

@jackfoxy
Copy link
Collaborator Author

updated the PR with binding redirects

@jackfoxy
Copy link
Collaborator Author

@dsyme I don't know what other branch to send PR to
I was responding to your request https://github.com/fslaborg/FsLab/issues/137#issuecomment-406582666
As you see from my comments, still a problem with build script. I'm working on it now. Happy to have other eyes on it.

@jackfoxy
Copy link
Collaborator Author

@dsyme this is almost certainly a Paket problem, since I can get my changes to build with "native" nuget.

fsprojects/Paket#3309

I'll give paket some time to respond before I update this PR.

@jackfoxy
Copy link
Collaborator Author

@dsyme

  1. merged with prior changes to master
  2. paket issue resolved (user error)

ready to merge with master

@jackfoxy
Copy link
Collaborator Author

fixed the Travis build

@jackfoxy jackfoxy merged commit c42e00a into fslaborg:master Jul 30, 2018
@jackfoxy jackfoxy deleted the magicmode branch July 30, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackfoxy @dsyme