fix for Go 1.10 #34

wadey · 2018-02-20T15:56:48Z

Fixes #33 and #31.

A couple of fixes so that fsevents builds in Go 1.10. Sadly this breaks
compatibility with Go 1.9 and below, but there doesn't seem to be any
way to avoid that. I have not fully vetted it, just confirmed that it builds and the example runs.

the kFSEventStreamEventIdSinceNow type is now correctly unsigned, so
the the need to convert from a signed integer is no longer needed.
nil must be changed to 0 in a few places now.
We must cast to the correct C type in a few places.

A couple of fixes so that fsevents builds in Go 1.10. Sadly this breaks compatibility with Go 1.9 and below, but there doesn't seem to be any way to avoid that. - the `kFSEventStreamEventIdSinceNow` type is now correctly unsigned, so the the need to convert from a signed integer is no longer needed. - nil must be changed to 0 in a few places now. - We must cast to the correct C type in a few places.

nilleb · 2018-02-20T16:18:23Z

we could perhaps use the flag go1.10 changing a little the file organization (in order not to break the backwards compatibility? I volunteer to do that)

wadey · 2018-02-20T16:23:39Z

For a quick fix could just make a complete copy of the old wrap.go and put it behind the build flag and not waste time on reorganization

nilleb · 2018-02-20T16:51:56Z

mh, no, unfortunately it won't work. unless we don't modify the before_script part of the job
(in fact, the go1.9 means from go 1.9 onward, thus will be always compiling this file -- creating conflicts with the 1.10 one)

There were backwards incompatible changes to cgo in Go 1.10: - https://golang.org/doc/go1.10#cgo

wadey · 2018-02-20T19:33:11Z

I pushed a change that should build for all versions of Go, the travis build passed for latest Xcode:

https://travis-ci.org/fsnotify/fsevents/jobs/343973059

It failed for the oldest version of Xcode though, for what seems like an unrelated issue. I'm testing building with multiple versions of Go now.

Test with Go 1.8, 1.9, 1.10 and latest stable (in case we forget to update this later). sw_vers is only present on the osx_image builds so make the output for it conditional.

codecov-io · 2018-02-20T21:25:13Z

Codecov Report

Merging #34 into master will decrease coverage by 0.32%.
The diff coverage is 41.4%.

@@            Coverage Diff            @@
##           master     #34      +/-   ##
=========================================
- Coverage   43.03%   42.7%   -0.33%     
=========================================
  Files           2       3       +1     
  Lines         165     288     +123     
=========================================
+ Hits           71     123      +52     
- Misses         84     147      +63     
- Partials       10      18       +8

Impacted Files	Coverage Δ
wrap.go	`42.51% <20%> (ø)`	⬆️
wrap_deprecated.go	`42.27% <42.27%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ceee05...a2c2f90. Read the comment docs.

wadey · 2018-02-20T21:37:31Z

Ok, I've pushed some changes to the Travis config so that it tests with Go 1.8, 1.9 and 1.10. All builds pass: https://travis-ci.org/fsnotify/fsevents/builds/344036544

nilleb · 2018-02-21T08:31:59Z

I hope this patch will be merged soon! :-)

drewwells · 2018-02-23T05:09:48Z

wrap_go1.9 probably would have been sufficient :D

drewwells · 2018-02-23T05:12:51Z

Testing this in my project, tests look good. We're losing some coverage b/c of the duplication of code

drewwells · 2018-02-23T05:37:17Z

great work, thank you for your contribution 🎉 🎉 🎉

This pulls in fsnotify/fsevents#34, which fixes Go 1.10+ support on mac OS.

* fix for Go 1.10 A couple of fixes so that fsevents builds in Go 1.10. Sadly this breaks compatibility with Go 1.9 and below, but there doesn't seem to be any way to avoid that. - the `kFSEventStreamEventIdSinceNow` type is now correctly unsigned, so the the need to convert from a signed integer is no longer needed. - nil must be changed to 0 in a few places now. - We must cast to the correct C type in a few places. * add wrap_deprecated.go for Go 1.9 and older There were backwards incompatible changes to cgo in Go 1.10: - https://golang.org/doc/go1.10#cgo * Update travis.yml Test with Go 1.8, 1.9, 1.10 and latest stable (in case we forget to update this later). sw_vers is only present on the osx_image builds so make the output for it conditional. * fix to work with Go 1.9.2+

Cherry pick of fsnotify#34 to enable Go 1.10 compilation. > * fix for Go 1.10 > > A couple of fixes so that fsevents builds in Go 1.10. Sadly this breaks > compatibility with Go 1.9 and below, but there doesn't seem to be any > way to avoid that. > > - the `kFSEventStreamEventIdSinceNow` type is now correctly unsigned, so > the the need to convert from a signed integer is no longer needed. > > - nil must be changed to 0 in a few places now. > > - We must cast to the correct C type in a few places. > > * add wrap_deprecated.go for Go 1.9 and older > > There were backwards incompatible changes to cgo in Go 1.10: > > - https://golang.org/doc/go1.10#cgo > > * Update travis.yml > > Test with Go 1.8, 1.9, 1.10 and latest stable (in case we forget to > update this later). sw_vers is only present on the osx_image builds so > make the output for it conditional. > > * fix to work with Go 1.9.2+

Go-version specific files. reworks #34 which resolves int overflow #31

@havoc-io

fixes #40 Cannot use nil for CFType (Go 1.10+), round 2 reducing code changes between Go versions conversions can occur in older Go versions too extract eventIDSinceNow constant to other files Go-version specific files. reworks #34 which resolves int overflow #31 minimize code differences between Go versions Work around bizarre bugs in 1.10.3 (not 1.10.4) golang/go#24161 use C.kCFAllocatorDefault instead of C.CFAllocatorRef(0) thanks to @havoc-io for the tip reduce duplication between go 1.10 before/after thanks to C.kCFAllocatorDefault change

@havoc-io

fixes #40 Cannot use nil for CFType (Go 1.10+), round 2 reducing code changes between Go versions conversions can occur in older Go versions too extract eventIDSinceNow constant to other files Go-version specific files. reworks #34 which resolves int overflow #31 minimize code differences between Go versions Work around bizarre bugs in 1.10.3 (not 1.10.4) golang/go#24161 use C.kCFAllocatorDefault instead of C.CFAllocatorRef(0) thanks to @havoc-io for the tip reduce duplication between go 1.10 before/after thanks to C.kCFAllocatorDefault change

@havoc-io

fixes fsnotify#40 Cannot use nil for CFType (Go 1.10+), round 2 reducing code changes between Go versions conversions can occur in older Go versions too extract eventIDSinceNow constant to other files Go-version specific files. reworks fsnotify#34 which resolves int overflow fsnotify#31 minimize code differences between Go versions Work around bizarre bugs in 1.10.3 (not 1.10.4) golang/go#24161 use C.kCFAllocatorDefault instead of C.CFAllocatorRef(0) thanks to @havoc-io for the tip reduce duplication between go 1.10 before/after thanks to C.kCFAllocatorDefault change

@havoc-io

fixes fsnotify#40 Cannot use nil for CFType (Go 1.10+), round 2 reducing code changes between Go versions conversions can occur in older Go versions too extract eventIDSinceNow constant to other files Go-version specific files. reworks fsnotify#34 which resolves int overflow fsnotify#31 minimize code differences between Go versions Work around bizarre bugs in 1.10.3 (not 1.10.4) golang/go#24161 use C.kCFAllocatorDefault instead of C.CFAllocatorRef(0) thanks to @havoc-io for the tip reduce duplication between go 1.10 before/after thanks to C.kCFAllocatorDefault change

@havoc-io

fixes fsnotify#40 Cannot use nil for CFType (Go 1.10+), round 2 reducing code changes between Go versions conversions can occur in older Go versions too extract eventIDSinceNow constant to other files Go-version specific files. reworks fsnotify#34 which resolves int overflow fsnotify#31 minimize code differences between Go versions Work around bizarre bugs in 1.10.3 (not 1.10.4) golang/go#24161 use C.kCFAllocatorDefault instead of C.CFAllocatorRef(0) thanks to @havoc-io for the tip reduce duplication between go 1.10 before/after thanks to C.kCFAllocatorDefault change

This was referenced Feb 20, 2018

Go 1.10 support #33

Closed

Error vendor/github.com/fsnotify/fsevents/wrap.go:38: constant 36893488147419103231 overflows uint64 #31

Closed

add wrap_deprecated.go for Go 1.9 and older

5c4b99a

There were backwards incompatible changes to cgo in Go 1.10: - https://golang.org/doc/go1.10#cgo

wadey added 2 commits February 20, 2018 16:22

Update travis.yml

ce8841a

Test with Go 1.8, 1.9, 1.10 and latest stable (in case we forget to update this later). sw_vers is only present on the osx_image builds so make the output for it conditional.

fix to work with Go 1.9.2+

a2c2f90

tylerjl mentioned this pull request Feb 21, 2018

auditbeat 6.2.2 Homebrew/homebrew-core#24363

Closed

drewwells approved these changes Feb 23, 2018

View reviewed changes

drewwells merged commit 5cff8fb into fsnotify:master Feb 23, 2018

ilovezfs mentioned this pull request Feb 23, 2018

auditbeat: add patch for Go 1.10 Homebrew/formula-patches#228

Merged

jansorg mentioned this pull request Mar 5, 2018

Support Go 1.10 kiteco/fsevents#1

Merged

andrewkroh mentioned this pull request Mar 11, 2018

[Auditbeat] Update fsevents dep for Go 1.10 compatibility elastic/beats#6524

Closed

mlarraz added a commit to enova/puma-dev that referenced this pull request Mar 25, 2018

Update vendored fsnotify/fsevents library

7c8223f

This pulls in fsnotify/fsevents#34, which fixes Go 1.10+ support on mac OS.

mlarraz mentioned this pull request Mar 25, 2018

Update vendored fsnotify/fsevents library puma/puma-dev#154

Merged

mlarraz added a commit to enova/puma-dev that referenced this pull request Mar 25, 2018

Update vendored fsnotify/fsevents library

bb96a9f

This pulls in fsnotify/fsevents#34, which fixes Go 1.10+ support on mac OS.

andrewkroh mentioned this pull request Apr 5, 2018

Fixes for Go 1.10 elastic/fsevents#3

Merged

nathany mentioned this pull request Aug 25, 2018

Failing test on Go 1.10+: cannot use nil as type... #40

Closed

nathany mentioned this pull request Aug 25, 2018

Improve handling of different Go versions, address compile failure in Go 1.10.4+ #41

Merged

nathany added a commit that referenced this pull request Aug 25, 2018

extract eventIDSinceNow constant other files

50d3b75

Go-version specific files. reworks #34 which resolves int overflow #31

nathany added a commit that referenced this pull request Aug 25, 2018

extract eventIDSinceNow constant other files

7521748

Go-version specific files. reworks #34 which resolves int overflow #31

nathany added a commit that referenced this pull request Aug 26, 2018

extract eventIDSinceNow constant to other files

50f89ad

Go-version specific files. reworks #34 which resolves int overflow #31

nathany added a commit that referenced this pull request Aug 26, 2018

extract eventIDSinceNow constant to other files

71492a6

Go-version specific files. reworks #34 which resolves int overflow #31

nathany added a commit that referenced this pull request Aug 26, 2018

extract eventIDSinceNow constant to other files

3e30862

Go-version specific files. reworks #34 which resolves int overflow #31

vjsamuel mentioned this pull request Oct 27, 2018

Fix for Go1.11 elastic/fsevents#4

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix for Go 1.10 #34

fix for Go 1.10 #34

wadey commented Feb 20, 2018

nilleb commented Feb 20, 2018

wadey commented Feb 20, 2018

nilleb commented Feb 20, 2018 •

edited

Loading

wadey commented Feb 20, 2018

codecov-io commented Feb 20, 2018 •

edited

Loading

wadey commented Feb 20, 2018

nilleb commented Feb 21, 2018

drewwells commented Feb 23, 2018

drewwells commented Feb 23, 2018

drewwells commented Feb 23, 2018

fix for Go 1.10 #34

fix for Go 1.10 #34

Conversation

wadey commented Feb 20, 2018

nilleb commented Feb 20, 2018

wadey commented Feb 20, 2018

nilleb commented Feb 20, 2018 • edited Loading

wadey commented Feb 20, 2018

codecov-io commented Feb 20, 2018 • edited Loading

Codecov Report

wadey commented Feb 20, 2018

nilleb commented Feb 21, 2018

drewwells commented Feb 23, 2018

drewwells commented Feb 23, 2018

drewwells commented Feb 23, 2018

nilleb commented Feb 20, 2018 •

edited

Loading

codecov-io commented Feb 20, 2018 •

edited

Loading