Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auditbeat] Update fsevents dep for Go 1.10 compatibility #6524

Closed
andrewkroh opened this issue Mar 11, 2018 · 1 comment · Fixed by #6790
Closed

[Auditbeat] Update fsevents dep for Go 1.10 compatibility #6524

andrewkroh opened this issue Mar 11, 2018 · 1 comment · Fixed by #6790
Assignees
@andrewkroh
Labels
Auditbeat

Comments

@andrewkroh
Copy link
Member

Auditbeat does not build under Go 1.10 due to issues with fsnotify/fsevents. We need to pull in the changes from fsnotify/fsevents#34.

$ go build
# github.com/elastic/beats/vendor/github.com/fsnotify/fsevents
../vendor/github.com/fsnotify/fsevents/wrap.go:119: cannot convert nil to type _Ctype_CFStringRef
../vendor/github.com/fsnotify/fsevents/wrap.go:176: cannot use cPaths (type _Ctype_CFArrayRef) as type _Ctype_CFMutableArrayRef in argument to func literal
../vendor/github.com/fsnotify/fsevents/wrap.go:232: cannot use es.rlref (type CFRunLoopRef) as type _Ctype_CFRunLoopRef in argument to func literal
../vendor/github.com/fsnotify/fsevents/wrap.go:268: cannot use rlref (type CFRunLoopRef) as type _Ctype_CFRunLoopRef in argument to func literal
@andrewkroh
Copy link
Member Author

I opened elastic/fsevents#3 to update the elastic fsevents fork.

@andrewkroh andrewkroh self-assigned this Apr 5, 2018
andrewkroh added a commit to andrewkroh/beats that referenced this issue Apr 6, 2018
@andrewkroh
Update github.com/fsnotify/fsevents
1f9ae94 
This fixes issues with compiling Auditbeat under Go 1.10.

Fixes elastic#6524
@andrewkroh andrewkroh mentioned this issue Apr 6, 2018
Merged
@ph ph closed this as completed in #6790 Apr 6, 2018
ph pushed a commit that referenced this issue Apr 6, 2018
@andrewkroh @ph
Update github.com/fsnotify/fsevents (#6790)
f4dd5ba 
* Update github.com/fsnotify/fsevents

This fixes issues with compiling Auditbeat under Go 1.10.

Fixes #6524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewkroh andrewkroh

Labels
Auditbeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update github.com/fsnotify/fsevents andrewkroh/beats
1 participant
@andrewkroh