Make commandline parameters case insensitive #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
reviewed
Nov 19, 2020
| if argInfo.CliParamIndex.Value.TryGetPrefix(token, &prefix, &case) then | ||
| if token = prefix then CliParam(token, prefix, case, NoAssignment) |> kont | ||
| if argInfo.CliParamIndex.Value.TryGetCaseInsensitivePrefix(token, &prefix, &case) then | ||
| if token.ToLower() = prefix.ToLower() then CliParam(token, prefix, case, NoAssignment) |> kont |
There was a problem hiding this comment.
String.Equals(token, prefix, StringComparison.OrdinalIgnoreCase)
|
Thanks, but I'm not sure I'm a fan of that particular change. I would prefer it if the library steered people towards adopting POSIX conventions for argument syntax:
Allowing camelCase should therefore not be supported by design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #155 - whether or not this is strictly necessary or not is up for debate: personally I prefer
--kebab-caseparameters, though for those that use--CamelCasethis would save adding a whole load of annotations.Will happily amend the documentation and provide an example if this is considered a desirable change.