Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a binding for ToggleButton.IsCheckedChangedEvent #283

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

Numpsy
Copy link
Collaborator

@Numpsy Numpsy commented Mar 15, 2023

refs this deprecation in Avalonia 11:

image

where IsCheckedChangedEvent is a new one.

This is perhaps a tad confusing in the bindings, where there is already an onIsCheckedChanged bound to IsCheckedProperty which is itself marked as obsolete, so not sure what the desired approach is there.

Copy link
Member

@JaggerJo JaggerJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but remove the old method before merging.

@JaggerJo JaggerJo merged commit da714e9 into fsprojects:master Mar 29, 2023
@Numpsy Numpsy deleted the rw/ischeckedchanged branch March 29, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants