Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup output for gitlab writer #2478

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

baronfel
Copy link
Contributor

@baronfel baronfel commented Mar 5, 2020

  • don't write ansi escape codes because gitlab does that now, and
  • sanitize the KnownTags descriptions to prevent line overlaps

Description

After #2477 I tested the output on my work builds and got output like:

[37;2msection_start:1583446351:target_Clean
\e[0K[0m
[37;2msection_start:1583446351:target_ReplaceTemplateFilesNamespace
\e[0K[0m
[0Ksection_start:1583446308:restore_cache
[0Ksection_end:1583446309:restore_cache
[0Ksection_start:1583446309:download_artifacts
[0Ksection_end:1583446311:download_artifacts
[0Ksection_start:1583446311:build_script

Problems I see:

  • newlines in the tag descriptions
  • ansi escape codes from the ansi color output writer

So I corrected both of these.

don't write ansi escape codes because they do that now, and sanitize the KnownTags descriptions to prevent line overlaps
@matthid matthid merged commit f648878 into fsprojects:release/next Mar 6, 2020
@baronfel baronfel deleted the gitlab-reporter-tweaks branch March 6, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants