Complete the AST according to the June 2018 GraphQL spec edition #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some code-docs so that developers using the AST can read about what they are doing - Add TypeSystemDefinition and TypeSystemExtension to the Definition DU - Move DirectiveLocation from TypeSystem to Ast - Update usages
|
Is this wanted? |
|
Hi @haf I sent you a message on gitter a few days ago. We're definitely wanting this PR, but since this is a breaking change we're waiting until we complete the other 2.0 changes in. |
|
@haf is it relevant? |
|
Relevant: Yes, IMO without seeing what work of mine that authors of this repo duplicated. Can rebase: no, sorry, not without payment. The code is as-is and I'm fine with it being rejected or merged, whichever suits you best. |
|
@haf, pinged you in F# Slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what they are doing