Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of NUnit3 #83

Merged
merged 5 commits into from
Jan 31, 2016
Merged

Support of NUnit3 #83

merged 5 commits into from
Jan 31, 2016

Conversation

sergey-tihon
Copy link
Member

#82

@sergey-tihon
Copy link
Member Author

Here I need a help to migrate two custom constrains

  1. https://github.com/sergey-tihon/FsUnit/blob/master/src/FsUnit.NUnit/FsUnit.fs#L10-L18
  2. https://github.com/sergey-tihon/FsUnit/blob/master/src/FsUnit.NUnit/FsUnit.Extra.fs#L6-L14
    // cc @et1975 @damageboy

@Evangelink
Migrate custom constraints to NUnit3
d0b537e 
Based on NUnit3 source code I propose the following migration of the
custom constraints.
- We should add tests to prove the WriteDescriptionTo method migration
is doing what is intended.
- The F#-friendly formatting has been partially merged. We need to
decide if the EqualConstraintResult class is good enough or if we
inherit it and make it F#-friendly.
@Evangelink
Copy link
Contributor

@sergey-tihon There is a PR (sergey-tihon#1) on your forked repository.
Don't know if there is a way to link it here so we have a chat only in one thread so I am copy-pasting my comment here:

Based on NUnit3 source code I propose the following migration of the custom constraints.

  • We should add tests to prove the WriteDescriptionTo method migration is doing what is intended.
  • The F#-friendly formatting has been partially merged. We need to decide if the EqualConstraintResult class is good enough or if we inherit it and make it F#-friendly.

@sergey-tihon
Copy link
Member Author

@et1975 where did you found info about pluggable formatters in NUnit?

@sergey-tihon sergey-tihon mentioned this pull request Jan 27, 2016
Merged
@Evangelink
Copy link
Contributor

But WriteActualValueTo did it previously

If you look between NUnit3 and NUnit2 for the XmlSerializableConstraint class you will see the actual value is no longer displayed/printed. It seems it is now handled by the ConstraintResult class.

@et1975 has opened an issue about that on NUnit.

@sergey-tihon
Copy link
Member Author

Coool! Thank you @et1975

@sergey-tihon sergey-tihon changed the title [WIP] Support of NUnit3 Support of NUnit3 Jan 27, 2016
sergey-tihon added a commit that referenced this pull request Jan 31, 2016
@sergey-tihon
Merge pull request #83 from sergey-tihon/master
7b7f8df 
Support of NUnit 3.0
@sergey-tihon sergey-tihon merged commit 7b7f8df into fsprojects:master Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergey-tihon @Evangelink