Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support equivalent of PrivateAssets="All" #2951

Closed
ctaggart opened this issue Dec 28, 2017 · 4 comments
Closed

support equivalent of PrivateAssets="All" #2951

ctaggart opened this issue Dec 28, 2017 · 4 comments

Comments

@ctaggart
Copy link
Contributor

ctaggart commented Dec 28, 2017 •
edited
Loading

See #2930 and ctaggart/SourceLink#288. I'm looking for the equivalent of this, but using paket:

  <ItemGroup>
    <PackageReference Include="SourceLink.Create.CommandLine" Version="2.7.2" PrivateAssets="All" />
    <PackageReference Include="SourceLink.Embed.PaketFiles" Version="2.7.2" PrivateAssets="All" />
  </ItemGroup>
@ctaggart ctaggart changed the title support equivelant of PrivateAssets="All" support equivalent of PrivateAssets="All" Dec 28, 2017
@forki
Copy link
Member

forki commented Dec 28, 2017

Will look into this tomorrow. If I find time...

@forki forki closed this as completed in 85f3c9e Dec 29, 2017
@forki
Copy link
Member

forki commented Dec 29, 2017

ok please retry with latest version. we reuse the copy_local settings. If copy_local is set to true, then this should set the PrivateAssets attribute to "All".

You need latest paket.exe and Paket.Restore.targets

/cc @enricosada

@ctaggart
Copy link
Contributor Author

ctaggart commented Dec 29, 2017 •
edited
Loading

Thanks @forki! Trying it out on Argu now.

@ctaggart
Copy link
Contributor Author

It worked great. Here is how I updated Argu to SourceLink 2:
https://github.com/fsprojects/Argu/pull/97/files

@atlemann atlemann mentioned this issue Sep 12, 2018
Merged
@Dzoukr Dzoukr mentioned this issue Feb 19, 2021
Merged
@bartelink bartelink mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @ctaggart