Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket should import build targets from packages in dependency groups #1674

Merged
merged 1 commit into from
May 10, 2016

Conversation

sergey-tihon
Copy link
Member

Not sure it is directly related to #1663
But after paket.exe update with version 2.64.2, paket removed by build targets from project file
image

@sergey-tihon sergey-tihon changed the title Paket should import build targets for packages in dependency groups Paket should import build targets from packages in dependency groups May 10, 2016
@inosik
Copy link
Contributor

inosik commented May 10, 2016

The problem is the group name "Build". Other names seem to work fine.

Seems to be the same kind of problem as we had with "Lib"-named packages.

@sergey-tihon
Copy link
Member Author

sergey-tihon commented May 10, 2016

@inosik How group name affects Paket behavior?

@inosik
Copy link
Contributor

inosik commented May 10, 2016

It expects .targets and .props files to be directly in packages/Foo/build/ or in a framework specific sub-directory.

Now, if a group is named "Build", you get a path like packages/build/Foo/build/Foo.targets. I assume Paket checks only if Foo.targets is in packages/build/ or in packages/build/{framework}/, and if it isn't, it considers it as ignorable.

I tried installing the package from your screenshot and Paket installed it correctly when the group wasn't named "Build". With "Build", it didn't import the .targets file.

@sergey-tihon
Copy link
Member Author

Just wonder how it worked before )

@forki
Copy link
Member

forki commented May 10, 2016

@inosik so it's a string trimming issue, right?

@inosik
Copy link
Contributor

inosik commented May 10, 2016

I think so. We had something similar with packages which ended with "Lib", but I can't find the issue right now.

@forki
Copy link
Member

forki commented May 10, 2016

@sergey-tihon if we have a repro I will try to fix it

@forki forki closed this May 10, 2016
@forki forki reopened this May 10, 2016
@sergey-tihon
Copy link
Member Author

@forki This PR is repro

@forki forki merged commit c71fab3 into fsprojects:master May 10, 2016
forki added a commit that referenced this pull request May 10, 2016
@sergey-tihon
Copy link
Member Author

It works!
Thanks again @forki !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants