-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paket should import build targets from packages in dependency groups #1674
Conversation
The problem is the group name "Build". Other names seem to work fine. Seems to be the same kind of problem as we had with "Lib"-named packages. |
@inosik How group name affects Paket behavior? |
It expects Now, if a group is named "Build", you get a path like I tried installing the package from your screenshot and Paket installed it correctly when the group wasn't named "Build". With "Build", it didn't import the |
Just wonder how it worked before ) |
@inosik so it's a string trimming issue, right? |
I think so. We had something similar with packages which ended with "Lib", but I can't find the issue right now. |
@sergey-tihon if we have a repro I will try to fix it |
@forki This PR is repro |
It works! |
Not sure it is directly related to #1663
But after
paket.exe update
with version2.64.2
, paket removed by build targets from project file