Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureBlobFileSystem: remove socket_timeout #338

Merged
merged 2 commits into from
Oct 1, 2022

Conversation

dtrifiro
Copy link
Contributor

socket_timeout option is not being used

closes #303

@TomAugspurger
Copy link
Contributor

Thanks! Could you do this as a deprecation warning to avoid breaking code that was passing that?

Since we use None for the default, you'd need something like

# top-level
_socket_timeout_default = object()

def __init__(self, ... socket_timeout=_socket_timeout_default, ...):
    # in __init__
    if socket_timeout is not _socket_timeout_default:
        warnings.warn("message", FutureWarning)

adlfs/spec.py Outdated Show resolved Hide resolved
@hayesgb hayesgb merged commit f888ccd into fsspec:main Oct 1, 2022
@dtrifiro dtrifiro deleted the remove-socket-timeout branch October 3, 2022 07:53
@falkerson
Copy link

Hi folks, how to set timeout then? For example in #112 it isn't clear what was happening, it just was closed. What if process hang on waiting data or something? How we can force methods like read_block to raise some exception instead of wait indefinitely and waste resource?

efiop added a commit to efiop/adlfs that referenced this pull request Oct 2, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 2, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 2, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 2, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
efiop added a commit to efiop/adlfs that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureBlobFileSystem: socket_timeout ignored
4 participants