Respect onerror='return' in AzureBlobFileSystem.cat #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds an option to keep paths in the output set of AzureBlobFileSystem._expand_path even when the blob doesn't exist. This change is motivated by the onerror='return' option in cat, one of the callers of _expand_path (or expand_path). The stripping of none-existing paths undermines the onerror='return' and onerror='omit' in cat.
ErlendHaa
force-pushed
the
respect-onerror
branch
from
46af134
to
2486009
Compare
Merged
|
Thanks for this contribution @ErlendHaa! It was failing the linter. I patch this and merged your changes in. |
|
Hi again! as far as I can see #353 did not include this change? |
|
@hayesgb I checked the main branch, I don't see these changes either. The #353 didn't capture changes by @ErlendHaa, which is strange, it was based on his fork. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I noticed that the
AzureBlobFileSystem.catdoes not respect the onerror='return' (and 'omit'). Essentially, none-existing paths are always removed from the out set. This also causes problems upstream, e.g. infspec.FSmap.getitems[1] because this method expects to filter the path's itself. The result is aKeyErrorevery time the key-set includes none-existing blob.