Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiobotocore to 2.3.0 #622

Merged
merged 2 commits into from
May 6, 2022
Merged

aiobotocore to 2.3.0 #622

merged 2 commits into from
May 6, 2022

Conversation

achimgaedke
Copy link
Contributor

closes #558

@martindurant
Copy link
Member

This is still installing 2.2.0 in CI: https://github.com/fsspec/s3fs/runs/6323249228?check_suite_focus=true#step:4:24 . Can you please update the install line in the workflow at https://github.com/fsspec/s3fs/blob/main/.github/workflows/ci.yml#L36 ?

@achimgaedke
Copy link
Contributor Author

This is still installing 2.2.0 in CI: https://github.com/fsspec/s3fs/runs/6323249228?check_suite_focus=true#step:4:24 .

I see, done. Great that the conda-forge package was built immediately.

@martindurant martindurant merged commit 8abb586 into fsspec:main May 6, 2022
@martindurant
Copy link
Member

As a follow up, it may also be time to consider the aiohttp version.

@achimgaedke
Copy link
Contributor Author

As a follow up, it may also be time to consider the aiohttp version.

I had a look, aiohttp 4 isn't released and therefore 3.8.1 seems to be the standard - both for aiobotoccore and this library.

@martindurant
Copy link
Member

OK

@jmleoni
Copy link
Contributor

jmleoni commented May 13, 2022

@martindurant thank you for this merge. Do you think you can issue a release so this change can be used with installations of s3fs done from pypi ?

@achimgaedke
Copy link
Contributor Author

Probably needs some testing on different OS, but did some updating towards release here. #623

I use this version successfully on ubuntu 22.04.

@achimgaedke achimgaedke deleted the update-aiobotocore branch May 16, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 error : Unable to locate credentials
3 participants