Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry on "reduce your request rate" #865

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

pingsutw
Copy link
Contributor

@pingsutw pingsutw commented Mar 21, 2024

Retry the request when we get the error (reduce your request rate).

We have 2000+ tasks, each running in the K8s pod and uploading multiple files to a certain bucket. We get reduce your request rate error because s3fs doesn't retry this request

https://stackoverflow.com/questions/46787072/s3-slowdown-please-reduce-your-request-rate-exception

image

@pingsutw
Copy link
Contributor Author

@martindurant mind taking a look? It will be great to cut a release once we merge it. We have some production workflow blocked by this.

@martindurant
Copy link
Member

The specific change here is to add "reduce your request rate" as a retriable condition? For reference, can you put details of the exception here, since I don't think this is one we've seen before.

s3fs/core.py Outdated Show resolved Hide resolved
@pingsutw
Copy link
Contributor Author

image

Signed-off-by: Kevin Su <pingsutw@gmail.com>
@pingsutw
Copy link
Contributor Author

@martindurant does it make sense

@martindurant martindurant merged commit 11ec756 into fsspec:main Mar 21, 2024
21 checks passed
@martindurant martindurant changed the title fix(s3fs): Consolidate retry logic for rate limits retry on "reduce your request rate" Mar 21, 2024
@pingsutw
Copy link
Contributor Author

@martindurant sorry to ping you again. qq: do we have an ETA for release?

@martindurant
Copy link
Member

Not certain yet, there are a few things in flight. There's always at least one release per month.

@pingsutw
Copy link
Contributor Author

Got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants