Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpython pathlib tests #104

Merged
merged 13 commits into from
Jun 21, 2023
Merged

cpython pathlib tests #104

merged 13 commits into from
Jun 21, 2023

Conversation

ap--
Copy link
Collaborator

@ap-- ap-- commented Jun 17, 2023

This adds the current cpython pathlib tests to universal_pathlib.

Tests are taken from this point in the commit history: https://github.com/python/cpython/blob/10bf2cd404320252ef162d5699cb7ce52a970d44/Lib/test/test_pathlib.py

The pathlib tests are by default deselected via the pathlib marker (see pyproject.toml).

The hdfs skip logic has been removed too in favour of simply deselecting the hdfs marker.
The --skiphdfs commandline options has been removed too. Use -m 'not hdfs' instead.
To enable pathlib tests run pytest -m pathlib upath. Default is -m 'not (hdfs or pathlib)'.

@ap--
Copy link
Collaborator Author

ap-- commented Jun 20, 2023

Waiting for #105

@ap-- ap-- merged commit 0f5f418 into fsspec:main Jun 21, 2023
@ap-- ap-- deleted the cpython-pathlib-tests branch July 18, 2023 22:27
@ap-- ap-- mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant