Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema extractor should take aliases into account #133

Closed
fstaudt opened this issue Oct 17, 2023 · 0 comments
Closed

JSON schema extractor should take aliases into account #133

fstaudt opened this issue Oct 17, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@fstaudt
Copy link
Owner

fstaudt commented Oct 17, 2023

When JSON schemas are extracted from dependencies, aliases used for sub-charts are ignored.

As a result, aggregated JSON schema incorrectly uses the chart name instead of the alias for the sub-charts.

Example

dependent-chart/Chart.yaml:

apiVersion: v2
name: dependent-chart
version: 0.1.0
description: Dependent helm chart with alias in dependencies
dependencies:
  - name: sub-chart
    version: 0.1.0
    repository: "@thirdparty"
    alias: alias-chart

main-chart/Chart.yaml:

apiVersion: v2
name: main-chart
version: 0.1.0
description: Main helm chart
dependencies:
  - name: dependent-chart
    version: 0.1.0
    repository: "@thirdparty"

main-chart/values.yaml:

dependent-chart:
  sub-chart:             # is incorrectly documented and auto-completed
  alias-chart:           # is incorrectly considered as invalid
@fstaudt fstaudt added the bug Something isn't working label Oct 17, 2023
@fstaudt fstaudt added this to the 0.8.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant