Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart.yaml should be correctly parsed when dependency contain no version or repository #28

Closed
fstaudt opened this issue Nov 14, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@fstaudt
Copy link
Owner

fstaudt commented Nov 14, 2022

When a dependency in Chart.yaml does not contain a version or repository, the YAML parser fails with following exception:

java.security.PrivilegedActionException: java.security.PrivilegedActionException: com.fasterxml.jackson.module.kotlin.MissingKotlinParameterException: Instantiation of [simple type, class io.github.fstaudt.helm.model.ChartDependency] value failed for JSON property repository due to missing (therefore NULL) value for creator parameter repository which is a non-nullable type
 at [Source: (FileInputStream); line: 15, column: 1] (through reference chain: io.github.fstaudt.helm.model.Chart["dependencies"]->java.util.ArrayList[2]->io.github.fstaudt.helm.model.ChartDependency["repository"])

Parsing should succeed and JSON schema generation should take into account the fact that version or repository is missing:

  • download should ignore dependencies without version or repository
  • extract should extract JSON schemas when dependency has no repository
  • extract should ignore dependencies without version
  • generateValuesJsonSchema should ignore dependencies without version or repository
  • generateValuesJsonSchema should set property for dependency condition for dependencies without version or repository
  • aggregate should skip dependencies without version
  • aggregate should aggregate extracted JSON schemas for dependency without repository
@fstaudt fstaudt added the bug Something isn't working label Nov 14, 2022
@fstaudt fstaudt added this to the 0.4.0 milestone Nov 14, 2022
@fstaudt fstaudt self-assigned this Nov 14, 2022
fstaudt added a commit that referenced this issue Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant