This repository has been archived by the owner on Sep 24, 2022. It is now read-only.
NamedTupleCursor factory test is executed even if MOMOKO_TEST_HSTORE is disabled #159
Comments
|
Good point. Indeed, please go ahead with pull request if you can. |
friedcell
added a commit
to friedcell/momoko
that referenced
this issue
Jul 13, 2023
* commit '0356e64c913016a6b375f836763b3f188193c1a5': (29 commits) version bump Fixed exclude format Ignoring vim swap files Properly skipping psycopg2 buils on pypy Fixed typo in Tornado 5.x compatability fixed quoting Support for Tornado 5.0! Hopefully fixes FSX#164 Trying pypy3.5 Yet another attempt for Python2.7 Enabling 3.7 the right wat in travis Python 2.7 compatibility Attempting to fix Python 3.7 on Travis Python 3.3 is deprecated Python 3.7 support! Fixes FSX#165 Testing that RealDictCursor works with JSON. Fixes FSX#154. Testing hstore separately from json. Fixes FSX#159. Fixing resource warnings. Thanks Python! Tornado does not support Python2.6. So do we. Fix tcproxy build error tornado version < 5.0 ... # Conflicts: # .gitignore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The unit test
test_cursor_factory_with_extensionsis testing that NamedTupleCursor factory is working with both hstore and json.However, if
MOMOKO_TEST_HSTOREis disabled we should only test json !A quick fix would be to split the unit test in:
test_cursor_factory_with_json_extensionto test JSONtest_cursor_factory_with_hstore_extensionto test HSTORE extension and add the following decorator@unittest.skipIf(not test_hstore, "Skipping test as requested")Is it OK for you ? Would you like that I make a pull request with it ?
The text was updated successfully, but these errors were encountered: