Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATABASE] improve mdl_club.py #23

Closed
fsxfreak opened this issue Feb 19, 2017 · 1 comment
Closed

[DATABASE] improve mdl_club.py #23

fsxfreak opened this issue Feb 19, 2017 · 1 comment
Assignees
@JiaxiWuAccount @ShijieFan
Milestone
alpha

Comments

@fsxfreak
Copy link
Owner

#20 applies to club_description
club_type should be enumerated? Currently the passerby can speciffy whatever club type they want, don't we want it to be PUBLIC/PRIVATE?
@fsxfreak fsxfreak added the bug label Feb 19, 2017
@fsxfreak fsxfreak added this to the alpha milestone Feb 19, 2017
@fsxfreak fsxfreak mentioned this issue Feb 19, 2017
Closed
JiaxiWuAccount added a commit that referenced this issue Feb 19, 2017
#23 fixed
4300099
@fsxfreak fsxfreak mentioned this issue Feb 21, 2017
Closed
@fsxfreak
Copy link
Owner Author

looks good to me, though the naming convention could use some work. minor issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaxiWuAccount JiaxiWuAccount

@ShijieFan ShijieFan

Labels
None yet
Projects
None yet
Milestone
alpha
Development

No branches or pull requests
3 participants
@fsxfreak @JiaxiWuAccount @ShijieFan