Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CrossVersion.full to use CrossVersion.patch for Typelevel Scala compatibility. #261

Merged
merged 2 commits into from
Mar 5, 2017

Conversation

ClydeMachine
Copy link
Contributor

Including text from the issue at typelevel/scala#135:

To use Typelevel Scala versions which are not exactly aligned with the corresponding Lightbend Scala version (ie. because they include an additional -bin-patch-nnn suffix in their version) we need to modify project builds which use CrossVersion.full (which includes the suffix) to use CrossVersion.patch (which doesn't) where appropriate (eg. for macro-paradise and other compiler plugins).

Replaced the aforementioned, as well as updating the use of "org.scala-lang" to scalaOrganization.value in library dependencies. The line below remains, as swapping that straight out obviously doesn't work since org.scala-lang.modules is a whole separate package from org.scala-lang. The project builds successfully with this left in, so please advise if this will also need changing, or if it's no problem as is.

Seq("org.scala-lang.modules" %% "scala-xml" % scalaXmlVersion)

@codecov-io
Copy link

codecov-io commented Mar 4, 2017

Codecov Report

Merging #261 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          36       36           
  Lines         409      409           
  Branches       18       18           
=======================================
  Hits          406      406           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a67bc...fb345d5. Read the comment docs.

@fthomas
Copy link
Owner

fthomas commented Mar 5, 2017

I think this is fine as is since there is no scala-xml under org.typelevel.
Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants