Unify numeric type class instances #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A type class that converts the type `A` to a value of type `B`.
... to `type MaxSize[N] = Size[Interval.Closed[_0, N]]` and use `AsValueOf` for the `Arbitrary` instance of `Interval.Closed[L, H]` so that we can generate instances where the LUB of `L` and `H` is `Any` (as for example in ``Interval.Closed[_0, W.`10`.T]``).
The instances with `AsValueOf` works for both `Nat` and primitive types.
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 94.47% 93.05% -1.42%
==========================================
Files 61 62 +1
Lines 688 677 -11
Branches 12 12
==========================================
- Hits 650 630 -20
- Misses 38 47 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the definition of
MaxSize[N]fromSize[LessEqual[N]]toSize[Interval.Closed[_0, N]]and adds theWitnessAstype class which unifies numeric type class instances that were split to work with literal singleton types andshapeless.Nat.Closes #473