Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvm list default behaviour #97

Open
marblegravy opened this issue Oct 12, 2017 · 4 comments
Open

dvm list default behaviour #97

marblegravy opened this issue Oct 12, 2017 · 4 comments

Comments

@marblegravy
Copy link
Contributor

dvm list on it's own throws an error in 2.3

| => dvm list
FATA[0000] expected 1 argument, 0 found

Suggest it's default behaviour triggers help text to describe the available flags. Perhaps something like:

| => dvm list -h
List available or installed Drush versions.

Usage:
  dvm list [commands] [flags]

Commands:
  available    Lists all versions of drush that can be installed
  installed     Lists all versions of drush that are already installed

Flags:
  -h, --help   help for list

Global Flags:
      --config string   config file (default is $HOME/config.toml)
@fubarhouse
Copy link
Owner

fubarhouse commented Oct 13, 2017

I'd love to do this - I just need to figure out how to invoke it from a subcommand...

It would help me out in a number of other places.

Edit: figured it out :)

Commit it on the way.

Any templating changes will need to be templated or otherwise handled.

fubarhouse added a commit that referenced this issue Oct 13, 2017
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
fubarhouse added a commit that referenced this issue Oct 13, 2017
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
fubarhouse added a commit that referenced this issue Oct 13, 2017
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
@fubarhouse
Copy link
Owner

So this achieves the desired result, the program knows about the flag, rather than it being arbitrary.

Please leave some feedback when you find some time.

@fubarhouse
Copy link
Owner

Please advise of any further change within the next week - I'm looking at releasing v2.4.0.

@fubarhouse
Copy link
Owner

  • Have the changes improved the intent of this issue?
  • Was it intended to set the default behaviour to list available, or installed versions where no flag is provided, and if so, which option would be preferable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants