tests: add bhyveload mock #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfreyer
force-pushed
the
test-harness
branch
from
984b01a
to
899bf94
Compare
fabianfreyer
changed the title
fabianfreyer
force-pushed
the
test-harness
branch
2 times, most recently
from
5bc466f
to
da96cf3
Compare
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
====================================
Coverage 0% 0%
====================================
Files 3 3
Lines 222 222
====================================
Misses 222 222Continue to review full report at Codecov.
|
fabianfreyer
commented
Feb 16, 2018
tests/test-mock-bhyveload.c
Outdated
| @@ -34,6 +34,9 @@ | |||
| #define MiB (size_t) (1024 * 1024) | |||
| #define GiB (size_t) (1024 * 1024 * 1024) | |||
|
|
|||
| /* copyin into in the highmem is currently not supported by bhyveload. */ | |||
| #define TEST_HIGHMEM_ALLOCATION 0 | |||
There was a problem hiding this comment.
usr.sbin/bhyveload/bhyveload.c:338:
to &= 0x7fffffff;Looks like highmem copyins go to lowmem, so we disable highmem allocation here.
fabianfreyer
commented
Feb 16, 2018
tests/mock/bhyveload.c
Outdated
| strlcpy(path, host_base, PATH_MAX); | ||
| if (path[strlen(path) - 1] == '/') | ||
| path[strlen(path) - 1] = 0; | ||
| strlcat(path, filename, PATH_MAX); |
There was a problem hiding this comment.
strlcat and strlcpy are not portable:
mock/bhyveload.c:87:2: warning: implicitly declaring library function 'strlcpy'
with type 'unsigned long (char *, const char *, unsigned long)'
[-Wimplicit-function-declaration]
strlcpy(path, host_base, PATH_MAX);
^
mock/bhyveload.c:87:2: note: include the header <string.h> or explicitly provide
a declaration for 'strlcpy'
mock/bhyveload.c:90:2: warning: implicitly declaring library function 'strlcat'
with type 'unsigned long (char *, const char *, unsigned long)'
[-Wimplicit-function-declaration]
strlcat(path, filename, PATH_MAX);
^
d01a928
to
58aef22
Compare
Implement a mock object implementing most of the callbacks of userboot.so allowing access to the emulated state. Tests for these mock callbacks are implemented.
|
I'll squash the above commits when merging this issue. |
fabianfreyer
force-pushed
the
test-harness
branch
from
391fbeb
to
b6fbc96
Compare
fabianfreyer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1