Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default instance of for books should be "written work" #130

Closed
davidscotson opened this issue Aug 25, 2023 · 3 comments
Closed

Default instance of for books should be "written work" #130

davidscotson opened this issue Aug 25, 2023 · 3 comments

Comments

@davidscotson
Copy link

At the moment an instance of "book" is suggested, then changed to "edition" if an isbn is detected.

A default of "written work" would follow the wikidata book project defaults better.

(The presence of a page number count could also switch from "written work" to "edition" but that's probably a rare corner case and not worth worrying about)

@fuddl
Copy link
Owner

fuddl commented Aug 26, 2023

Thanks for your feedback. unfortunatly, the issue lies deeper.

Where exactly (link) did you find it?

I expect that this website will describe the entity as itemtype="https://schema.org/Book", which according to wikidata is "book".

Other websites might have a slightly different data model than wikidata. in this case you should uncheck the proposed property

@davidscotson
Copy link
Author

I thought I'd tracked this in the code to here, (though I admit I hadn't actually tested changing it):

https://github.com/fuddl/wd/blob/aeb049f571ae72af31f719e96b8bd9c17a3a08fa/src/content/content__collect-meta.js#L18C18-L18C21

Where it sets the Q571 based on the opengraph tag.

An example that is currently unlinked to wikidata is here:

https://openlibrary.org/works/OL221334W/Blue_Highways?edition=ia%3Abluehighways00will

I'll give changing that line a go and see if it has any effect.

fuddl pushed a commit that referenced this issue Aug 28, 2023
@fuddl
Copy link
Owner

fuddl commented Sep 9, 2023

i think this is fixed

@fuddl fuddl closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants