Add missing code to render pagination when generated from oil generate admin command #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findrakecil
commented
Dec 12, 2018
| @@ -27,10 +27,12 @@ | |||
| </td> | |||
| </tr> | |||
| <?php echo '<?php endforeach; ?>'; ?> | |||
| <?php echo $pagination;?> | |||
There was a problem hiding this comment.
I removed this line because it was inside the table block
There was a problem hiding this comment.
Also, this was not the correct code to generate the code to render pagination
findrakecil
commented
Dec 12, 2018
| </tbody> | ||
| </table> | ||
|
|
||
| <?php echo '<?php'; ?> echo $pagination <?php echo '?>'; ?> |
There was a problem hiding this comment.
I moved the code to render pagination here, outside of table block. And this is the correct code generate the code to render pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix issue #261