Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use data_key when available for property names #139

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Use data_key when available for property names #139

merged 1 commit into from
Mar 2, 2021

Conversation

martijnthe
Copy link
Contributor

A field has an optional data_key which can hold an alternative
output key name. When dumping a schema, the data_key should be
used instead of the name.

@coveralls
Copy link

coveralls commented Feb 25, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 99.149% when pulling 4edeb67 on martijnthe:martijnthe/data_key into 4a74842 on fuhrysteve:master.

@martijnthe
Use data_key when available for property names
4edeb67 
A field has an optional `data_key` which can hold an alternative
output key name. When dumping a schema, the `data_key` should be
used instead of the name.
@fuhrysteve
Copy link
Owner

this makes sense to me! data_key is a new concept in marshmallow v3, so it's not surprising that we aren't always handling data_key correctly. Thanks for the PR!

@fuhrysteve fuhrysteve merged commit 88ca54f into fuhrysteve:master Mar 2, 2021
fuhrysteve added a commit that referenced this pull request Mar 2, 2021
@fuhrysteve
add #139 (data_key support) to changelog
2565bc0
This was referenced Mar 2, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martijnthe @coveralls @fuhrysteve