Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flash messages functionality #75

Closed
wants to merge 1 commit into from
Closed

Conversation

blasut
Copy link
Contributor

@blasut blasut commented Nov 22, 2015

Flash messages are used when you need information to persist after an action as an redirect. Write or read mode is decided by if a pass a parameter to the function or call it without parameters. The function is defined in src/web.lisp. The flash function is based on the functionality in Rails.

@fukamachi
Copy link
Owner

Looks great.
However, I think it would be better to be defined in helper.lisp, not in skeleton/ since it's too simple and small utility.
Will you rewrite the patch (or will I)?

@blasut
Copy link
Contributor Author

blasut commented Dec 16, 2015

If the patch can wait for some time, then I can do it. If you feel like changing it, it would be appreciated

Not a lot of time right now.

@fukamachi
Copy link
Owner

Sure, I can wait.
2015年12月16日(水) 18:51 blasut notifications@github.com:

If the patch can wait for some time, then I can do it. If you feel like
changing it, it would be appreciated

Not a lot of time right now.


Reply to this email directly or view it on GitHub
#75 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants