Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #40

Merged
merged 10 commits into from
Feb 23, 2021
Merged

Fix failing tests #40

merged 10 commits into from
Feb 23, 2021

Conversation

egfrank
Copy link
Contributor

@egfrank egfrank commented Feb 11, 2021 •
edited
Loading

In this PR, I had to both

  • Change the testing setup so that Github Actions are deploying the docker container tests
  • Fix failing tests still in ixctl so entire test suite passes. This mostly just entailed moving tests to fullctl that had previously just been left behind

This would close #39

@egfrank egfrank mentioned this pull request Feb 11, 2021
Closed
@vegu vegu merged commit d83894e into master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing tests
2 participants
@egfrank @vegu