Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bb/refactor component #3

Merged
merged 11 commits into from
Dec 7, 2016
Merged

Bb/refactor component #3

merged 11 commits into from
Dec 7, 2016

Conversation

beeman
Copy link
Contributor

@beeman beeman commented Nov 30, 2016

No description provided.

@mrfelton
Copy link

mrfelton commented Nov 30, 2016 •
edited
Loading

Looks good @beeman . A couple of additional things that I think should be included though:

  • add unit tests to verify ACL functionality
  • document how to use ACLs

@mrfelton mrfelton assigned beeman and unassigned mrfelton Nov 30, 2016
mrfelton
mrfelton suggested changes Nov 30, 2016
View reviewed changes
Copy link

@mrfelton mrfelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docs and tests for ACLs

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.5%) to 95.536% when pulling dd9b7d4 on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.5%) to 95.536% when pulling 934679c on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 96.429% when pulling ec55b1b on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 94.643% when pulling 6d0a195 on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 94.643% when pulling c696d03 on bb/refactor-component into 6b5525d on master.

@mrfelton mrfelton force-pushed the bb/refactor-component branch 3 times, most recently from f85dcb4 to 4509e00 Compare December 6, 2016 10:50
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.1%) to 92.857% when pulling 4509e00 on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.1%) to 92.857% when pulling 9445e4c on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.1%) to 92.857% when pulling 1aa0e82 on bb/refactor-component into 6b5525d on master.

@mrfelton mrfelton force-pushed the bb/refactor-component branch 3 times, most recently from 71d4903 to 4102813 Compare December 6, 2016 11:07
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.1%) to 92.857% when pulling 4102813 on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.1%) to 92.857% when pulling 1143e80 on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-71.9%) to 28.09% when pulling 1394141 on bb/refactor-component into 6b5525d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.5%) to 96.522% when pulling 245a254 on bb/refactor-component into 6b5525d on master.

@beeman beeman merged commit 7870634 into master Dec 7, 2016
@beeman beeman deleted the bb/refactor-component branch December 7, 2016 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrfelton mrfelton mrfelton requested changes

Assignees

@beeman beeman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beeman @mrfelton @coveralls