Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(getSettings): added generic type for getSetting function #146

Merged
merged 5 commits into from
Dec 22, 2018

Conversation

NarHakobyan
Copy link
Contributor

@NarHakobyan NarHakobyan commented Oct 29, 2018

** PR Checklist
Please check if your PR fulfills the following requirements:

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: N/A

** What is the new behavior?

** Does this PR introduce a breaking change?

[ ] Yes
[x] No

** Other information

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #146   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          80     80           
  Branches       14     14           
=====================================
  Hits           80     80
Impacted Files Coverage Δ
packages/@ngx-config/core/src/config.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe1c70...28610fc. Read the comment docs.

@fulls1z3 fulls1z3 merged commit e1cb64b into fulls1z3:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants