Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): migrate to ng9 #161

Merged
merged 1 commit into from
Apr 27, 2020
Merged

feat(package): migrate to ng9 #161

merged 1 commit into from
Apr 27, 2020

Conversation

fulls1z3
Copy link
Owner

** PR Checklist
Please check if your PR fulfills the following requirements:

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: N/A

** What is the new behavior?

** Does this PR introduce a breaking change?

[ ] Yes
[x] No

** Other information

BREAKING CHANGE

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #161 into master will decrease coverage by 2.37%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   97.97%   95.60%   -2.38%     
==========================================
  Files           9        9              
  Lines          99       91       -8     
  Branches       12       12              
==========================================
- Hits           97       87      -10     
- Misses          2        4       +2     
Impacted Files Coverage Δ
packages/@ngx-config/core/src/config.module.ts 80.00% <50.00%> (-10.91%) ⬇️
packages/@ngx-config/core/src/config.pipe.ts 100.00% <0.00%> (ø)
packages/@ngx-config/core/src/config.loader.ts 100.00% <0.00%> (ø)
packages/@ngx-config/core/src/config.service.ts 100.00% <0.00%> (ø)
.../@ngx-config/http-loader/src/config.http-loader.ts 100.00% <0.00%> (ø)
...ngx-config/merge-loader/src/config.merge-loader.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730d1a4...ae8df83. Read the comment docs.

@ghost
Copy link

ghost commented Apr 27, 2020

Warnings are found on analyzing the commit ae8df83.

2 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

@fulls1z3 fulls1z3 merged commit 58fdac3 into master Apr 27, 2020
@fulls1z3 fulls1z3 deleted the ng9 branch April 27, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant