feat(package): migrate to ng12

[JonnyBGod]

** PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?
Does not compile for Angular 12 apps.

Issue Number: #167

** What is the new behavior?

Should work with Angular 12.

** Does this PR introduce a breaking change?

[ ] Yes
[x] No

[ghost]

Sider has detected 2 warnings on analyzing the commit de08e48.

• ⚠️ Goodcheck
• ⚠️ TSLint

If the errors persist even after retrying, the following actions may resolve them:

• Update tool dependencies
• Configure failed tools
• Configure sider.yml
• Turn off unused tools

If you still have problems, feel free to ask us via chat. 💬

---

You can turn off such notifications if unnecessary.

[JonnyBGod]

@fulls1z3 Circle ci is not working for this project due to key configuration problem.

[JonnyBGod]

@fulls1z3 Any news on this? We are really stuf at this point waiting for this lib to support Angular 12.

[stephanabel]

@fulls1z3 Any chance to get this merged in the near future? This is basically the only thing blocking us from using Angular 12.

[fulls1z3]

@JonnyBGod need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

• update deps ngx-meta#216
• update deps #169
• update deps ngx-cache#141
• update deps ngx-auth#135

and finally we're showcasing it on fulls1z3/universal#755

[JonnyBGod]

Sure I can help with this but as far as I know the lib worked fine with ng10 and ng11 even if not with the ideal build.
It only broke for ng12. I don’t see any point on baking specific releases for legacy versions if they were supported unless I am missing something.

Also this fix should also make it compatible with ng 10 and 11.

[JonnyBGod]

@fulls1z3 can you give me write access to the relevant repos so I can patch your PRs?

[fulls1z3]

@JonnyBGod i invited you as collaborator, so you have write access. lib works in ng 10 & 11 but need to roll out for each version to maintain backwards compatibility but also upgrading it & testing in real life on each major release

[fulls1z3]

@JonnyBGod and the actual problem is with "yarn build" and it will fail on upper releases as well

[matusbielik]

@fulls1z3 I was able to successfully build the library and use it locally with Angular 12 project (using npm link). Do you need any help with this? Really many people are waiting on this and it's taking too long.

The problem in CircleCI seems to be with private key configuration, the platform can't even clone the repo to begin with. It seems that only you can fix this, I believe you must provide key generated by Github to the CircleCI so it has access.

[fulls1z3]

@JonnyBGod @matusbielik here is the output i'm getting when building http-loader since it depends on the core package.these paths are clearly pointed in tools/build/tsconfig.package.json into the bundles in dist, but still not getting any luck.

➜  fulls1z3-ngx-config git:(update_deps) yarn build:http-loader
yarn run v1.22.10
$ ng-packagr -p packages/@ngx-config/http-loader/package.json -c tools/build/tsconfig.package.json
Building Angular Package

------------------------------------------------------------------------------
Building entry point '@ngx-config/http-loader'
------------------------------------------------------------------------------
Compiling TypeScript sources through ngc
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
ERROR: packages/@ngx-config/http-loader/src/config.http-loader.ts:3:30 - error TS2307: Cannot find module '@ngx-config/core' or its corresponding type declarations.

3 import { ConfigLoader } from '@ngx-config/core';
                               ~~~~~~~~~~~~~~~~~~

error Command failed with exit code 111.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

i see angular team changed the way paths are resolved from tsconfig, and not any of my efforts are helping out. i'm thinking of archiving this project since i can't go further, not any help from community and not enough time to invest to tackle this particular issue.

[matusbielik]

@fulls1z3 when do you experience this problem? Isn't it only problem on your local configuration (typescript version etc)?

I was able to build all three packages when I tried to upgrade the library myself, and I also tried to build the code from this PR (JonnyBGod's remote's last commit to master) and it went without any problems (npm run build / yarn build).

So maybe it is not an issue and this PR can go?

I understand that you want to archive this project if you are not willing to develop it any further, but please do so after we upgrade and publish v12 compatible version. The library still has 1.2k weekly downloads, it is blocker for upgrade for many projects!

If there is any way to help, just say. As ngx-config is heavily used in our application and getting rid of it would be huge rewrite, the only other option for my team was to publish patched library to npm under another name so we can use it to build the app (tried and it works locally with npm link)... But I don't like the idea, it's your code and I find it as plagiarism :)

We are very close to making this compatible with v12 for everybody so let's not back down now :)

[JonnyBGod]

@fulls1z3 can you try to fix the problem with circleci. With that working we can better see if there is a problem with the build.

On my local environment all PR I create are working and tested locally with production projects via "npm link".

[JonnyBGod]

Also one opinion I would like to give.

I see your point on making it right and going back to make sure the libs support all past Angular versions and I would gladly help with it if I had the time, but lets be honest, these libs are mostly nice to haves that I want to help support but not core libs that need the very best care. Giving that apparently all interested parties lack the time to do everything by the book I think we should just focus on the pressing matter that is to support the latest angular version and unblock everyone that wants to update to it.

I am happy to then help anyone with issues with previous versions if those come up. (I believe it wont as I have been using the libs with all Angular versions until now with no problems.)

[JonnyBGod]

@fulls1z3 any news on this?
It has been almost 2 months now. Can you fix the circleci ssh key so we can move on?
If you do that and authorize to merge, I can take care of making sure everything is working fine.

[harryt04]

Any news on this? Our team is blocked from upgrading angular until this is fixed or we rip out this plugin and use a new one. And we are using it in a lot of places in production, so I really want to avoid ripping it out :(